Skip to content

feat(tests): EIP-198 modexp cases with truncated inputs#2180

Merged
marioevz merged 2 commits intoethereum:forks/amsterdamfrom
monad-developers:feat/modexp-test
Feb 17, 2026
Merged

feat(tests): EIP-198 modexp cases with truncated inputs#2180
marioevz merged 2 commits intoethereum:forks/amsterdamfrom
monad-developers:feat/modexp-test

Conversation

@pdobacz
Copy link
Copy Markdown
Contributor

@pdobacz pdobacz commented Feb 10, 2026

🗒️ Description

Test case authored by Category Labs team in category-labs/monad#2045

Adds cases with truncated inputs to modexp. Checked to pass with Hive.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (720caf4) to head (411f15f).
⚠️ Report is 24 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2180   +/-   ##
================================================
  Coverage            86.07%   86.07%           
================================================
  Files                  599      599           
  Lines                39472    39472           
  Branches              3780     3780           
================================================
  Hits                 33977    33977           
  Misses                4862     4862           
  Partials               633      633           
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Test case authored by Category Labs team in category-labs/monad#2045

Co-authored-by: Baltoli <1329034+Baltoli@users.noreply.github.com>
Copy link
Copy Markdown
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have more such tests in evmone.

RazorClient pushed a commit to RazorClient/execution-specs that referenced this pull request Feb 11, 2026
…doc-line-too-long) (ethereum#2180)

* split comments across multiple lines when necessary

* chore(tooling): check w505 in tox lint env

* fixes

* chore: remove abstract and other admonitions from test module docstrings

* fixes

* chore: fix more malformatted tables

* chore: fix broken unordered-lists/args

* chore: fix broken unordered-lists/args

* chore: improve docstrings, also for D205

* chore: improve docstrings, also for D205

* chore: fix long or poorly formatted comments

* chore: manually revert and fix docstrings/comments

* fix: bad string formatting fix in unit test

* last batch of manual fixes

* fix

* fix

---------

Co-authored-by: danceratopz <danceratopz@gmail.com>
RazorClient pushed a commit to RazorClient/execution-specs that referenced this pull request Feb 11, 2026
…doc-line-too-long) (ethereum#2180)

* split comments across multiple lines when necessary

* chore(tooling): check w505 in tox lint env

* fixes

* chore: remove abstract and other admonitions from test module docstrings

* fixes

* chore: fix more malformatted tables

* chore: fix broken unordered-lists/args

* chore: fix broken unordered-lists/args

* chore: improve docstrings, also for D205

* chore: improve docstrings, also for D205

* chore: fix long or poorly formatted comments

* chore: manually revert and fix docstrings/comments

* fix: bad string formatting fix in unit test

* last batch of manual fixes

* fix

* fix

---------

Co-authored-by: danceratopz <danceratopz@gmail.com>
Copy link
Copy Markdown
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor nit on the test IDs, but overall LGTM, thanks!

Comment thread tests/byzantium/eip198_modexp_precompile/test_modexp.py Outdated
Comment thread tests/byzantium/eip198_modexp_precompile/test_modexp.py Outdated
Comment thread tests/byzantium/eip198_modexp_precompile/test_modexp.py Outdated
Comment thread tests/byzantium/eip198_modexp_precompile/test_modexp.py Outdated
Co-authored-by: Mario Vega <marioevz@gmail.com>
@pdobacz pdobacz requested a review from marioevz February 16, 2026 07:51
@marioevz marioevz merged commit 4914e58 into ethereum:forks/amsterdam Feb 17, 2026
15 checks passed
@pdobacz pdobacz deleted the feat/modexp-test branch February 17, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants