fix(tooling): correct codespell skip patterns for fixture directories#2218
Merged
marioevz merged 1 commit intoethereum:forks/amsterdamfrom Feb 16, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2218 +/- ##
================================================
Coverage 86.07% 86.07%
================================================
Files 599 599
Lines 39472 39472
Branches 3780 3780
================================================
Hits 33977 33977
Misses 4862 4862
Partials 633 633
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
flcl42
pushed a commit
to flcl42/execution-specs
that referenced
this pull request
Apr 10, 2026
Synthesize the `p256verify` precompile inputs where `u1 == u2` in two variants: `Q == G` and `Q != G`. In the first variant the computation of `R` involves point doubling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Fix codespell
skippatterns for downloaded fixture directories.Problem
uvx tox -e staticfails whentests/json_infra/fixtures/*directories are present on disk (written byuv run pytest tests/json_infra/), because codespell scans upstream files (e.g., the MD/YAML in ethereum/tests) that we won't fix.For example:
Solution
The existing skip entries
"tests/fixtures"and"tests/json_infra/fixtures"never matched as codespell'sos.walk(".")yields./-prefixed paths andfnmatchrequires an exact match. Prefixing with*makes the glob match correctly without over-broadly skipping our own source files underpackages/testing/src/execution_testing/fixtures/.🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture