Skip to content

fix(tooling): correct codespell skip patterns for fixture directories#2218

Merged
marioevz merged 1 commit intoethereum:forks/amsterdamfrom
danceratopz:codespell-skip-ethereum_tests
Feb 16, 2026
Merged

fix(tooling): correct codespell skip patterns for fixture directories#2218
marioevz merged 1 commit intoethereum:forks/amsterdamfrom
danceratopz:codespell-skip-ethereum_tests

Conversation

@danceratopz
Copy link
Copy Markdown
Member

@danceratopz danceratopz commented Feb 16, 2026

🗒️ Description

Fix codespell skip patterns for downloaded fixture directories.

Problem

uvx tox -e static fails when tests/json_infra/fixtures/* directories are present on disk (written by uv run pytest tests/json_infra/), because codespell scans upstream files (e.g., the MD/YAML in ethereum/tests) that we won't fix.

For example:

uvx tox -e static
ROOT: will run in automatically provisioned tox, host /home/dtopz/.cache/uv/archive-v0/mo6-Wrg-_q6Me3v2cZHAH/bin/python is missing [requires (has)]: tox-uv<2,>=1.29
ROOT: provision> .tox/.tox/bin/python -m tox -e static
static: uv-sync> uv sync --locked --python-preference system -p /home/dtopz/code/github/execution-specs.spec-version-lint/.tox/.tox/bin/python
static: commands[0]> codespell
./tests/json_infra/fixtures/ethereum_tests/CHANGELOG.md:63: exisitng ==> existing
./tests/json_infra/fixtures/ethereum_tests/PRLOG.md:14: ambiguos ==> ambiguous
./tests/json_infra/fixtures/ethereum_tests/PRLOG.md:21: ambigous ==> ambiguous
./tests/json_infra/fixtures/ethereum_tests/PRLOG.md:25: differencies ==> differences
./tests/json_infra/fixtures/ethereum_tests/PRLOG.md:86: defult ==> default

Solution

The existing skip entries "tests/fixtures" and "tests/json_infra/fixtures" never matched as codespell's os.walk(".") yields ./-prefixed paths and fnmatch requires an exact match. Prefixing with * makes the glob match correctly without over-broadly skipping our own source files under packages/testing/src/execution_testing/fixtures/.

🔗 Related Issues or PRs

N/A.

✅ Checklist

Cute Animal Picture

image

@danceratopz danceratopz changed the title fix: correct codespell skip patterns for fixture directories fix(tooling): correct codespell skip patterns for fixture directories Feb 16, 2026
Copy link
Copy Markdown
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (83852d6) to head (9a4b9cd).
⚠️ Report is 2 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2218   +/-   ##
================================================
  Coverage            86.07%   86.07%           
================================================
  Files                  599      599           
  Lines                39472    39472           
  Branches              3780     3780           
================================================
  Hits                 33977    33977           
  Misses                4862     4862           
  Partials               633      633           
Flag Coverage Δ
unittests 86.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marioevz marioevz merged commit d0a3751 into ethereum:forks/amsterdam Feb 16, 2026
15 checks passed
flcl42 pushed a commit to flcl42/execution-specs that referenced this pull request Apr 10, 2026
Synthesize the `p256verify` precompile inputs where `u1 == u2` in two
variants: `Q == G` and `Q != G`. In the first variant the computation of
`R` involves point doubling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants