Skip to content

Fixed svg example#2821

Open
k4k7us23 wants to merge 1 commit intofacebook:mainfrom
k4k7us23:fix/svg_example
Open

Fixed svg example#2821
k4k7us23 wants to merge 1 commit intofacebook:mainfrom
k4k7us23:fix/svg_example

Conversation

@k4k7us23
Copy link
Copy Markdown

Motivation

Fixes broken example of loading svg using fresco. Fixes #2820

Test Plan

Vito's java implementation

  1. Launch showcase project
  2. Open svg screen using sidebar menu
  3. Enable toggle "Svg support enable"
  4. Press "kill now" in an appeared dialog
  5. Open showcase application
  6. Make sure fresco's svg logo is displayed
svg shown using vito java impl

Vito's kotlin implementation

  1. Launch showcase project
  2. Open settings screen using sidebar menu
  3. Enable vito -> "Use kotlin implemention" setting
  4. Open svg screen using sidebar menu
  5. Enable toggle "Svg support enable"
  6. Press "kill now" in an appeared dialog
  7. Open showcase application
  8. Make sure fresco's svg logo is displayed
svg shown using vito kotlin impl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Svg example in showcase project doesn't work

2 participants