Skip to content

fix surface BUCK, and CI #24404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dulmandakh wants to merge 6 commits into from
Closed

fix surface BUCK, and CI #24404

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d1bdfa
fix surface BUCK, and CI
dulmandakh Apr 11, 2019
b59b2d4
fix support:annotation target
dulmandakh Apr 11, 2019
d63974a
annotations target
dulmandakh Apr 11, 2019
b44e9ca
trigger ci
dulmandakh Apr 11, 2019
7047cd0
use support-v4 as whole
dulmandakh Apr 11, 2019
cb00db6
remove unused BUCK
dulmandakh Apr 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ReactAndroid/src/main/java/com/facebook/react/surface/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("@fbsource//tools/build_defs/oss:rn_defs.bzl", "YOGA_TARGET", "react_native_dep", "react_native_target", "rn_android_library")
load("//tools/build_defs/oss:rn_defs.bzl", "YOGA_TARGET", "react_native_dep", "react_native_target", "rn_android_library")

rn_android_library(
name = "surface",
Expand All @@ -10,7 +10,7 @@ rn_android_library(
deps = [
YOGA_TARGET,
react_native_dep("libraries/fbcore/src/main/java/com/facebook/common/logging:logging"),
react_native_dep("third-party/android/support-annotations:android-support-annotations"),
react_native_dep("third-party/android/support/v4:annotation"),
react_native_dep("third-party/java/infer-annotations:infer-annotations"),
react_native_dep("third-party/java/jsr-305:jsr-305"),
react_native_target("java/com/facebook/react/bridge:bridge"),
Expand Down