Fix: respect "withCredentials: false" in RCTNetworking iOS#24629
Closed
DimitryDushkin wants to merge 1 commit intofacebook:masterfrom
Closed
Fix: respect "withCredentials: false" in RCTNetworking iOS#24629DimitryDushkin wants to merge 1 commit intofacebook:masterfrom
DimitryDushkin wants to merge 1 commit intofacebook:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24080.
Summary
Even with
withCredentials: falsenetwork requests still sending cookies. Fix this behaviour according to https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/withCredentials.Changelog
[iOS] [Fixed] - Respect "withCredentials: false" in network requests
Test Plan
withCredentials: falseActual behaviour: "Cookies" header is present in request.
Expected behaviour: no "Cookies" header in request