Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix the testing script without -c
Changelog:
[Internal] - Testing script
Test Plan:
Tested locally that doesn't choke on version cheking
Testing for 0.73-RC3 with
-coption:RNTester + iOS + Hermes: ✅ for the build => ❌ App stuck at startup
RNTester + iOS + JSC: ✅ for the build => ❌ App stuck at startup
RNTester + Android + Hermes: ✅
RNTester + Android + JSC: ✅
RNTestProject + iOS + Hermes: ✅
RNTestProject + iOS + JSC: ✅
RNTestProject + Android + Hermes: ✅
RNTestProject + Android + JSC: ✅
Testing for 0.73-RC3 no
-coption:RNTester + iOS + Hermes: ✅
RNTester + iOS + JSC: ✅ for the build => ❌ App stuck at startup
RNTester + Android + Hermes: ✅
RNTester + Android + JSC: ✅
RNTestProject + iOS + Hermes: ✅
RNTestProject + iOS + JSC: ✅
RNTestProject + Android + Hermes: ✅
RNTestProject + Android + JSC: ✅