Skip to content

[CLI] Remove dependency on Ruby #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vjeux merged 5 commits into from
May 14, 2015
+65 −50
Merged

[CLI] Remove dependency on Ruby #440

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
132f8fa
1-1 port of init script to Nodejs
JoeStanton Mar 29, 2015
2e2e577
Require directly, don't spawn
JoeStanton May 14, 2015
9caee32
Linked with new local-cli, refactored
JoeStanton May 14, 2015
29325d7
Move init into local-cli
JoeStanton May 14, 2015
04832e5
Fixed stylistic issues
JoeStanton May 14, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 0 additions & 46 deletions init.sh
View file
Open in desktop

This file was deleted.

6 changes: 2 additions & 4 deletions local-cli/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@

var spawn = require('child_process').spawn;
var path = require('path');

var init = require('./init.js');
var install = require('./install.js');
var bundle = require('./bundle.js');

Expand Down Expand Up @@ -59,10 +61,6 @@ function run() {
// Here goes any cli commands we need to
}

function init(root, projectName) {
spawn(path.resolve(__dirname, '../init.sh'), [projectName], {stdio:'inherit'});
}

if (require.main === module) {
run();
}
Expand Down
62 changes: 62 additions & 0 deletions local-cli/init.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
'use strict';

var path = require('path');
var fs = require('fs');

function init(projectDir, appName) {
console.log('Setting up new React Native app in ' + projectDir);
var source = path.resolve(__dirname, '..', 'Examples/SampleApp');

walk(source).forEach(function(f) {
f = f.replace(source + '/', ''); // Strip off absolute path
if(f === 'project.xcworkspace' || f === 'xcuserdata') { return; }
Copy link
Copy Markdown
Contributor

@vjeux vjeux May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space after if. Also, can you put return; on its own line?


var replacements = {
'Examples/SampleApp/': '',
'../../Libraries/': 'node_modules/react-native/Libraries/',
'../../React/': 'node_modules/react-native/React/',
'SampleApp': appName
};

var dest = f.replace(/SampleApp/g, appName).replace(/^_/, ".");
copyAndReplace(
path.resolve(source, f),
path.resolve(projectDir, dest),
replacements
);
});

console.log('Next Steps:');
console.log(' Open ' + path.resolve(projectDir, appName) + '.xcodeproj in Xcode');
console.log(' Hit Run button');
console.log('');
}

function copyAndReplace(src, dest, replacements) {
if (fs.lstatSync(src).isDirectory()) {
if (!fs.existsSync(dest)) {
fs.mkdirSync(dest);
}
}
Copy link
Copy Markdown
Contributor

@vjeux vjeux May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: else in the same line as }

} else {

else {
var content = fs.readFileSync(src, 'utf8');
Object.keys(replacements).forEach(function(regex) {
content = content.replace(new RegExp(regex, 'g'), replacements[regex]);
Copy link
Copy Markdown
Contributor

@vjeux vjeux May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

none of the replacements are regexes nor need to be applied multiple times, can you not use a regex for it?

Copy link
Copy Markdown
Contributor Author

@JoeStanton JoeStanton May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only reason these are regex's is that I want to replace all occurrences of the token in each file. Really I need to escape the .'s though if I stick with this. I could instead use something like:

function replaceAll(str, search, replacement) {
  return str.split(search).join(replacement);
}

});
fs.writeFileSync(dest, content);
}
}

function walk(current) {
if(fs.lstatSync(current).isDirectory()) {
Copy link
Copy Markdown
Contributor

@vjeux vjeux May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: space after if

var files = fs.readdirSync(current).map(function(child) {
child = path.join(current, child);
return walk(child);
});
return [].concat.apply([current], files);
} else {
Copy link
Copy Markdown
Contributor

@vjeux vjeux May 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: you don't need else because you return

}
return [current];

but, I usually like to first clear the pre-conditions this way it removes many levels of indentation

if (!fs.lstatSync(current).isDirectory()) {
  return [current];
}

var files = fs.readdirSync(current).map(function(child) {
  child = path.join(current, child);
  return walk(child);
});
return [].concat.apply([current], files);

return [current];
}
}

module.exports = init;