Skip to content

Fix autoFocus for hydration content when it is mismatched #11737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaearon merged 11 commits into from
Dec 6, 2017
+35 −5
Merged

Fix autoFocus for hydration content when it is mismatched #11737

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
69ed76d
Fix autoFocus for hydration content when it is mismatched
koba04 Dec 1, 2017
3de8f10
Add a test for mismatched content
koba04 Dec 2, 2017
c04a922
Fix a test for production
koba04 Dec 2, 2017
c4f88f4
Fix a spec description and verify console.error output
koba04 Dec 3, 2017
716ef70
Run prettier
koba04 Dec 5, 2017
58edd22
finalizeInitialChildren always returns `true`
koba04 Dec 5, 2017
fdc314f
Revert "finalizeInitialChildren always returns `true`"
koba04 Dec 5, 2017
4421877
Add a TODO comment
koba04 Dec 5, 2017
e60822d
Update ReactServerRendering-test.js
gaearon Dec 6, 2017
2e96526
Update ReactServerRendering-test.js
gaearon Dec 6, 2017
b1fcd7c
Rewrite the comment
gaearon Dec 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions packages/react-dom/src/__tests__/ReactServerRendering-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,6 +372,27 @@ describe('ReactDOMServer', () => {
expect(element.firstChild.focus).not.toHaveBeenCalled();
});

it('should not focus on either server or client with autofocus={false} even if there is a markup mismatch', () => {
spyOnDev(console, 'error');

var element = document.createElement('div');
element.innerHTML = ReactDOMServer.renderToString(
<button autoFocus={false}>server</button>,
);
expect(element.firstChild.autofocus).toBe(false);

element.firstChild.focus = jest.fn();
ReactDOM.hydrate(<button autoFocus={false}>client</button>, element);

expect(element.firstChild.focus).not.toHaveBeenCalled();
if (__DEV__) {
expect(console.error.calls.count()).toBe(1);
expect(console.error.calls.argsFor(0)[0]).toBe(
'Warning: Text content did not match. Server: "server" Client: "client"',
);
}
});

it('should throw with silly args', () => {
expect(
ReactDOMServer.renderToString.bind(ReactDOMServer, {x: 123}),
Expand Down
14 changes: 8 additions & 6 deletions packages/react-dom/src/client/ReactDOM.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -625,7 +625,7 @@ const DOMRenderer = ReactFiberReconciler({
rootContainerInstance: Container,
): boolean {
setInitialProperties(domElement, type, props, rootContainerInstance);
return shouldAutoFocusHostComponent(type, props);
return true;
Copy link
Copy Markdown
Collaborator

@gaearon gaearon Dec 5, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good because now every host Fiber gets scheduled for an effect during commit. The whole point of returning a boolean is to avoid this, as ideally this should be a rare case.

},

prepareUpdate(
Expand Down Expand Up @@ -700,11 +700,13 @@ const DOMRenderer = ReactFiberReconciler({
newProps: Props,
internalInstanceHandle: Object,
): void {
((domElement: any):
| HTMLButtonElement
| HTMLInputElement
| HTMLSelectElement
| HTMLTextAreaElement).focus();
if (shouldAutoFocusHostComponent(type, newProps)) {
((domElement: any):
| HTMLButtonElement
| HTMLInputElement
| HTMLSelectElement
| HTMLTextAreaElement).focus();
}
},

commitUpdate(
Expand Down