fix[dynamic-scripts-injection]: unregister content scripts before registration#26765
Merged
hoxyq merged 1 commit intofacebook:mainfrom May 3, 2023
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #26756.
DevTools is failing to inject
__REACT_DEVTOOLS_GLOBAL_HOOK__hook in incognito mode. This is not happening straight-forward, but if extension is toggled on and off, the next time I try to open it I am receiving an error that content script was already registered.__REACT_DEVTOOLS_GLOBAL_HOOK__on each page, so this should be expected behaviour.How did you test this change?
Local build of extension for Chrome, trying the same steps, which resulted in an error.
No regression in performance, tested on react.dev, still the same.