Skip to content
This repository was archived by the owner on Oct 31, 2023. It is now read-only.

Dejan rebased on main#20

Open
dejangrubisic wants to merge 16 commits intomainfrom
dejan_rebased
Open

Dejan rebased on main#20
dejangrubisic wants to merge 16 commits intomainfrom
dejan_rebased

Conversation

@dejangrubisic
Copy link
Copy Markdown

This is rebased version of LoopTreeAgent.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2022
@bwasti
Copy link
Copy Markdown
Contributor

bwasti commented Jun 6, 2022

just as a quick heads up, you should be able to maintain the same PR by using the same branch (e.g. by renaming the new rebased version).

maybe something like this?

# save the old branch with a new name
git checkout dejan
git checkout -b dejan_orig_backup # just in case

# delete the old branch
git branch -D dejan

# rename the new rebased branch
git checkout dejan_rebase
git checkout -b dejan

# double check you've got the right changes
git log

# push it up!
git push origin dejan

I think that'd be better so we have a history of changes :)

@dejangrubisic
Copy link
Copy Markdown
Author

dejangrubisic commented Jun 6, 2022

e.g. by renaming the new rebased version).

Sure, done.

@facebook-github-bot
Copy link
Copy Markdown

Hi @dejangrubisic!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants