feat: avoid rewrapping response writer when capturing metrics#22
Open
costela wants to merge 3 commits intofelixge:masterfrom
Open
feat: avoid rewrapping response writer when capturing metrics#22costela wants to merge 3 commits intofelixge:masterfrom
costela wants to merge 3 commits intofelixge:masterfrom
Conversation
costela
force-pushed
the
avoid-duplicate-wrappings
branch
from
f98f37a to
d4ff2da
Compare
costela
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first attempt at addressing #19.
First we refactor the common code for
rwfrom being generated to sitting in its own file.Then we add an indirection to
Wrap, so that it becomes possible to associate the metrics with the returnedhttp.ResponseWriter.Then we add an interface to recover the
Metricsfrom a wrappedResponseWriter. If we can do that, then we directly call the wrapped function and return the existingMetrics.This unfortunately introduces an asymmetry: consumers of the library that use
Wrap()directly will not be able to useMetrics(). That kinda makes sense:Wrap()is not necessary used for metrics. We could move the metrics init toWrap()and always track them, but that would probably be an unexpected semantic change (with probable performance impact of its own). So I opted against it.WDYT? Does the general direction make sense?
Closes #19