Make SafeBuffer's prototype inherit from Buffer#23
Merged
feross merged 1 commit intofeross:masterfrom Jul 5, 2019
vkarpov15:patch-1
Merged
Make SafeBuffer's prototype inherit from Buffer#23feross merged 1 commit intofeross:masterfrom vkarpov15:patch-1
feross merged 1 commit intofeross:masterfrom
vkarpov15:patch-1
Conversation
vkarpov15
added a commit
to Automattic/mongoose
that referenced
this pull request
Oct 21, 2018
…because safe-buffer is broken for Node.js 4.x Fix #7102 Re: feross/safe-buffer#23
vkarpov15
added a commit
to Automattic/mongoose
that referenced
this pull request
Nov 5, 2018
This was referenced Nov 6, 2018
Owner
|
Thanks for the PR, this is released as 5.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: Automattic/mongoose#7102, you get annoying issues if you use SafeBuffer's prototype, like:
This fixes that