load experiments earlier

[bkendall]

Description

this allows them to be used once the CLI is imported, when everything starts loading and checking.

Scenarios Tested

Sample Commands

[gemini-code-assist]

Summary of Changes

Hello @bkendall, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request optimizes the initialization of experimental features within the Firebase CLI. By shifting the experiment loading mechanism to an earlier stage in the CLI's startup, it guarantees that experimental flags are active and accessible immediately upon module import. This change ensures that all subsequent components can leverage these flags from the very beginning of their loading and validation processes, improving consistency and reliability.

Highlights

• Experiment Initialization Timing: The enableExperimentsFromCliEnvVariable() function call has been moved to an earlier point in the src/bin/cli.ts file, ensuring experiments are loaded as soon as the CLI module is imported.
• Code Cleanup: A redundant call to enableExperimentsFromCliEnvVariable() within the cli function in src/bin/cli.ts has been removed, streamlining the initialization process.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly moves the initialization of CLI experiments to an earlier stage in the application lifecycle. By calling enableExperimentsFromCliEnvVariable() at the module level in src/bin/cli.ts, experiments are enabled as soon as the CLI is imported, ensuring experiment flags are respected throughout the code. I have one suggestion to improve the organization of the import statements for better readability and maintainability.

[gemini-code-assist]

For better code organization and adherence to common style practices, it's recommended to group all import statements at the top of the file. The function call that causes a side effect can then follow the import block. This separation of concerns improves readability and maintainability.

Suggested change

	import { configstore } from "../configstore";
	import { errorOut } from "../errorOut";
	import { logger, useFileLogger } from "../logger";
	import { enableExperimentsFromCliEnvVariable } from "../experiments";
	enableExperimentsFromCliEnvVariable();
	import * as client from "..";
	import * as fsutils from "../fsutils";
	import * as utils from "../utils";
	import { enableExperimentsFromCliEnvVariable } from "../experiments";
	import { fetchMOTD } from "../fetchMOTD";
	import { isCommandModule } from "../command";
	import { configstore } from "../configstore";
	import { errorOut } from "../errorOut";
	import { logger, useFileLogger } from "../logger";
	import { enableExperimentsFromCliEnvVariable } from "../experiments";
	import * as client from "..";
	import * as fsutils from "../fsutils";
	import * as utils from "../utils";
	import { fetchMOTD } from "../fetchMOTD";
	import { isCommandModule } from "../command";
	enableExperimentsFromCliEnvVariable();

[joehan]

Bad bot. Whole point of the PR is to make sure this happens before imports resolve.