Open
Conversation
floatmap/static/js/app.js
Outdated
| import L from 'leaflet'; | ||
| import { Base } from './layouts/Base'; | ||
|
|
||
| $(document).ready(() => { |
Contributor
Author
There was a problem hiding this comment.
Probably don't need this anymore.
mvattuone
force-pushed
the
feature/install-react
branch
from
0bff38d to
8867685
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces React and deprecates Backbone since we weren't really using models anyway.
This also introduces hot reloading via Webpack which is pretty handy. This will be even more useful once I set up a CSS bundle.
Leaflet and Shepherd rely heavily on the DOM to do what they do which makes it a little tricky incorporating them with React. Probably will be good to look for an alternative for Shepherd, though I don't know exactly how to reconcile the differences between Leaflet and React... there is probably a way.
Definitely needs some cleanup and tests. I'll add some comments explaining some of the more messy bits -- this will be refactored over time but wanted to get it working first.
@matteobanerjee