Skip to content

Fix wrong DNS query type in DANE lookups for IPv6-only hosts#632

Merged
foxcpp merged 1 commit intofoxcpp:masterfrom
cuihaoleo:fix-dane-wrong-query
Oct 12, 2023
Merged

Fix wrong DNS query type in DANE lookups for IPv6-only hosts#632
foxcpp merged 1 commit intofoxcpp:masterfrom
cuihaoleo:fix-dane-wrong-query

Conversation

@cuihaoleo
Copy link
Copy Markdown
Contributor

An apparent typo. This should fix #631.

The patch is tested on top of v0.7.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #632 (5d8f09e) into master (d9920f0) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #632      +/-   ##
==========================================
+ Coverage   52.39%   52.42%   +0.03%     
==========================================
  Files         128      128              
  Lines       13287    13287              
==========================================
+ Hits         6962     6966       +4     
+ Misses       5669     5666       -3     
+ Partials      656      655       -1     
Flag Coverage Δ
integration 34.03% <ø> (ø)
unit 53.84% <0.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
framework/dns/dnssec.go 28.07% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@foxcpp foxcpp merged commit 5724788 into foxcpp:master Oct 12, 2023
@foxcpp
Copy link
Copy Markdown
Owner

foxcpp commented Oct 12, 2023

Thanks!

@cuihaoleo cuihaoleo deleted the fix-dane-wrong-query branch October 12, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No usable MXs when sending to IPv6-only domain

3 participants