C++: Fix issue with cpp/incorrect-allocation-error-handling#17035
Merged
Conversation
Contributor
Author
|
Project build failures aside, the two DCA runs LGTM. We lose two results, which appear to be false positives of the kind described above. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix an issue with
cpp/incorrect-allocation-error-handlingthat was causing false positive results. The issue occurs when wenewa template type, and the constructor of that type can throw an exception in some instantiations but not in others. In these cases it's reasonable for the code to attempt to catch an exception, even though in some instantiations there cannot be one.