Java: Move SensitiveLoggerConfig source to extensible format#17036
Merged
Conversation
chmodxxx
changed the title
aschackmull
reviewed
Jul 23, 2024
aschackmull
reviewed
Jul 23, 2024
aschackmull
reviewed
Jul 23, 2024
Java: Make class private
Contributor
|
Do you think this needs a change note, @aschackmull ? |
Contributor
Yeah, I was just thinking about that as well - it might indeed be best to include that. |
Contributor
owen-mc
approved these changes
Jul 23, 2024
Contributor
Author
|
Hmm, not sure what's wrong with the CI integration test for Windows. Is it a flake ? |
Contributor
|
It doesn't seem like it could be related to your PR. I've restarted it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a need to do customizations on the sensitivelogger query where we need to extend the source of SensitiveLoggerConfiguration. Putting up this PR to see if I got things correctly .