Suggest using textContent instead of innerHTML#138
Merged
manuelpuyol merged 4 commits intomainfrom Sep 14, 2021
Merged
Conversation
JoseInTheArena
left a comment
JoseInTheArena
left a comment
There was a problem hiding this comment.
Thanks for putting this together! 🙇🏻♂️ I just have a small question about the copy on the docs.
Contributor
Author
|
per @koddsson request, I removed autocorrection since it was confusing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were suggesting using
innerHTMLto clear content, but that's the same astextContent = ''.This PR will block all uses of
innerHTMLand autocorrect to usetextContentinstead