Allow temporary IDs for all project operations#19573
Conversation
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
|
@copilot fix js tests |
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Fixed in 8cb353f. The TypeScript strict null check was failing because Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
Adds support for referencing newly-created GitHub Projects via temporary IDs (e.g. aw_... / #aw_...) so subsequent project operations can resolve the real project URL.
Changes:
- Store a temporary-id → project URL mapping when
create_projectsucceeds. - Resolve temporary project IDs from the shared
temporaryIdMapincreate_project_status_update. - Add unit tests covering temporary project ID resolution and not-found behavior for status updates.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| actions/setup/js/create_project_status_update.test.cjs | Adds tests validating temporary project ID resolution (with and without #) and failure behavior. |
| actions/setup/js/create_project_status_update.cjs | Resolves output.project when it’s a temporary ID by looking up projectUrl in the shared temp-id map. |
| actions/setup/js/create_project.cjs | Stores the created project URL in the shared temp-id map and returns temporaryId in the result. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ager convention Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Fixed in 2fa0350. The CI failure was caused by our branch being out of sync with |
create_project.cjs(normalizeTemporaryId(temporaryId ?? ""))create_project.cjshandler:(message, resolvedTemporaryIds, temporaryIdMap)to match manager conventioncreate_project_status_update.cjshandlerinstanceof Mapguards on alltemporaryIdMapread/write operations for safety(message, Object.fromEntries(temporaryIdMap), temporaryIdMap)action_pins.jsonwithorigin/main(addsdocker/login-action@v4,docker/setup-buildx-action@v4, updatessetup-dotnettov5.2.0, etc.)action_pins_logging_test.go: updatesetup-dotnettest case tov5.2.0action_pins_test.go: update pin count expectation from 32 to 34✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.