allow for customising of the hash return type as H#12
Merged
srt32 merged 2 commits intogithub:mainfrom Apr 17, 2023
Merged
Conversation
Contributor
Author
|
@srt32 would you kindly take a look at this |
|
To add some context. I'm working on a copilot PR and we would like to use an LRUCache implementation for the memoization cache. There's already an LRUCache implementation present within copilot, but w/o this change we're forced to create a wrapper for it because it can't be used directly. It would be nice to just use |
srt32
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow for the hashing return type to be properly typed by an implementation.