fix(config): route GitHub App token refresh to enterprise API_URL#137
Open
Ahmadshata wants to merge 1 commit intogithubexporter:masterfrom
Open
fix(config): route GitHub App token refresh to enterprise API_URL#137Ahmadshata wants to merge 1 commit intogithubexporter:masterfrom
Ahmadshata wants to merge 1 commit intogithubexporter:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes
GitHub App authenticationfor GitHub Enterprise environments by ensuring installation token refresh requests use the configuredAPI_URLinstead of defaulting toapi.github.com.Related Issues
Problem
When
GITHUB_APP=trueandAPI_URLpoints to GitHub Enterprise, API requests were correctly sent to the enterprise endpoint, but installation token refresh still targeted GitHub.com (/app/installations/{id}/access_tokens).This caused authentication failures (401) in enterprise deployments.
Root Cause
ghinstallation.Transportwas initialized, but itsBaseURLwas not overridden when a non-defaultAPI_URLwas configured.Changes
GetClient()inconfig/config.goto set:itr.BaseURL = c.ApiUrl.String()whenAPI_URLis nothttps://api.github.com.config/config_test.go:BaseURLis set to enterpriseAPI_URL.Validation
go test ./configgo test ./...Impact
API_URLsetups.Risk
Low.
The change is narrowly scoped to transport initialization for GitHub App auth and is covered by targeted regression testing.