Skip to content

chore: improve tests without assertions #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
czosel merged 3 commits into from
Mar 16, 2026
Merged

chore: improve tests without assertions #1201

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66b8f61
added assertion to the test
jorgsowa Mar 16, 2026
b424e9e
test: removed todo tests from namespace
jorgsowa Mar 16, 2026
8a6bc25
add assertions to string test
jorgsowa Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/ast.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ describe("Test AST class (edge cases)", function () {
debug: true,
},
});
test.parseEval("1 + 1;");
const ast = test.parseEval("1 + 1;");
expect(ast).toBeDefined();
});
it("test debug mode / errors", function () {
const test = parser.create({
Expand Down
107 changes: 107 additions & 0 deletions test/snapshot/__snapshots__/namespace.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,98 @@ Program {
}
`;

exports[`Test namespace statements check use 1`] = `
Program {
"children": [
UseGroup {
"items": [
UseItem {
"alias": null,
"kind": "useitem",
"name": "Foo\\Bar",
"type": null,
},
],
"kind": "usegroup",
"name": null,
"type": null,
},
UseGroup {
"items": [
UseItem {
"alias": null,
"kind": "useitem",
"name": "Foo\\A",
"type": null,
},
UseItem {
"alias": null,
"kind": "useitem",
"name": "Foo\\B",
"type": null,
},
UseItem {
"alias": null,
"kind": "useitem",
"name": "Foo\\C",
"type": null,
},
],
"kind": "usegroup",
"name": null,
"type": null,
},
UseGroup {
"items": [
UseItem {
"alias": null,
"kind": "useitem",
"name": "strlen",
"type": null,
},
],
"kind": "usegroup",
"name": null,
"type": "function",
},
UseGroup {
"items": [
UseItem {
"alias": null,
"kind": "useitem",
"name": "PHP_INT_MAX",
"type": null,
},
],
"kind": "usegroup",
"name": null,
"type": "const",
},
UseGroup {
"items": [
UseItem {
"alias": null,
"kind": "useitem",
"name": "SubA\\ClassA",
"type": null,
},
UseItem {
"alias": null,
"kind": "useitem",
"name": "SubB\\ClassB",
"type": null,
},
],
"kind": "usegroup",
"name": "Vendor\\Package",
"type": null,
},
],
"errors": [],
"kind": "program",
}
`;

exports[`Test namespace statements fix #246 - doesn't work properly for \`FULL_QUALIFIED_NAME\` 1`] = `
Program {
"children": [
Expand Down Expand Up @@ -1587,6 +1679,21 @@ Program {
}
`;

exports[`Test namespace statements test single namespace 2`] = `
Program {
"children": [
Namespace {
"children": [],
"kind": "namespace",
"name": "Foo",
"withBrackets": true,
},
],
"errors": [],
"kind": "program",
}
`;

exports[`Test namespace statements work with declare statement 1`] = `
Program {
"children": [
Expand Down
Loading
Loading