fix: attach doc comments to inner nodes in short-form if/elseif/else#1209
Merged
alexander-akait merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
alexander-akait
approved these changes
Mar 18, 2026
Collaborator
|
Released in v3.5.0 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1166
nowhere to attach and drifted to trailingComments on an unrelated node. Again, this aligns with read_code_block and read_short_form, which already had this guard.
Let me know if the second change is correct. The logic after the fix was not convincing to me, so I decided to align the behaviour for all blocks without children.