fix(contrib/registry/eureka): improve server picking and retry logic#3781
Open
1911860538 wants to merge 1 commit intogo-kratos:mainfrom
Open
fix(contrib/registry/eureka): improve server picking and retry logic#37811911860538 wants to merge 1 commit intogo-kratos:mainfrom
1911860538 wants to merge 1 commit intogo-kratos:mainfrom
Conversation
Contributor
Author
|
Reopen #3771 kratos/contrib/registry/eureka/client_test.gopackage eureka
import (
"context"
"testing"
)
// This test demonstrates an out-of-bounds panic in pickServer
// when maxRetry > len(urls).
func TestPickServer_OutOfBoundsPanic(t *testing.T) {
// len(urls) = 2
e := NewClient(
[]string{
"http://127.0.0.1:8080",
"http://127.0.0.1:8081",
},
WithMaxRetry(3), // > len(urls)
)
// This call will eventually invoke pickServer with currentTimes = 2,
// which leads to e.urls[2%3] == e.urls[2] and panics:
// runtime error: index out of range [2] with length 2
_ = e.Out(context.Background(), "app", "instance")
}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR fixes potential issues in the Eureka client's server picking and retry logic.
e.maxRetryis not necessarily equal tolen(e.urls),because users can customize
e.maxRetryusing theWithMaxRetryfunction.When users set e.maxRetry=0, the for-loop in the
Client.domethod will not execute.When
e.maxRetryis greater thanlen(e.urls), array index out of bounds may occur.For example, if a user sets e.maxRetry=10 and len(e.urls)=2,
when
pickServeris executed with currentTimes=2,currentTimes%e.maxRetry=2, resulting in an array index out of bounds.