feat: add BigLake Iceberg support for BigQuery analytics plugin#4749
feat: add BigLake Iceberg support for BigQuery analytics plugin#4749caohy1988 wants to merge 2 commits intogoogle:mainfrom
Conversation
Add `biglake_storage_uri` config option that, when set alongside `connection_id`, automatically creates BigLake managed Iceberg tables and replaces JSON schema fields with STRING (since BigLake Iceberg does not support JSON type). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the BigQuery analytics plugin by integrating support for BigLake managed Iceberg tables. This allows users to leverage BigLake's capabilities for external table management, providing a more flexible and scalable data storage solution. The changes include new configuration options, automatic schema adjustments to ensure compatibility with Iceberg's data types, and robust validation to guide proper usage. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
adk-bot
added
the
services
|
Response from ADK Triaging Agent Hello @caohy1988, thank you for your contribution! Before we can merge this PR, could you please sign our Contributor License Agreement (CLA)? You can find more information at https://cla.developers.google.com/. Also, for a new feature of this scope, please create a GitHub issue that describes the feature and associate it with this pull request. This will help us to track the new feature and review your PR more efficiently. Thanks! |
![gemini-code-assist[bot]](https://avatars.gh.lumenfield.work/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for BigLake managed Iceberg tables to the BigQuery analytics plugin. The changes are well-implemented, including the addition of the biglake_storage_uri configuration, schema transformation to handle JSON types, and setting the BigLakeConfiguration on table creation. The new tests are comprehensive and cover the new functionality thoroughly. I have one suggestion to remove a redundant validation check to improve code maintainability.
|
|
||
| if not self.config.connection_id: | ||
| raise ValueError( | ||
| "connection_id is required for BigLake Iceberg tables." | ||
| " Set it in BigQueryLoggerConfig." | ||
| ) |
There was a problem hiding this comment.
This validation check for connection_id is redundant. The __init__ method of BigQueryAgentAnalyticsPlugin already performs an identical check on lines 1905-1908. If self.is_biglake is true, it implies self.config.biglake_storage_uri is set, and the constructor would have already ensured self.config.connection_id is also set.
Removing this duplicate check will improve maintainability by centralizing the validation logic in the constructor, adhering to the "fail-fast" principle. The suggested change also removes the now-unnecessary blank line.
1. Normalize connection_id to full resource path for BigLakeConfiguration
(projects/{project}/locations/{loc}/connections/{name}).
2. Skip time partitioning for BigLake Iceberg by default (preview feature);
add biglake_time_partitioning opt-in flag.
3. Document Storage Write API latency caveat for Iceberg metadata refresh
(~90 min for open-source engine visibility).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2 participants
Summary
biglake_storage_uriconfig option toBigQueryLoggerConfigthat enables BigLake managed Iceberg table creationBigLakeConfiguration(connection_id, storage_uri, file_format=PARQUET, table_format=ICEBERG) on table creationconnection_idis provided whenbiglake_storage_uriis setTest plan
TestBigLakeIcebergcovering config, property, validation, schema transformation, Arrow metadata, and table creation🤖 Generated with Claude Code