Conversation
justinfagnani
approved these changes
Aug 22, 2024
README.md
Outdated
| between arguments intended for `node`, `wireit`, and the script itself: | ||
|
|
||
| ```sh | ||
| node --run build -- -- --verbose |
There was a problem hiding this comment.
It might be more clear to add a small template of who's args go where. Maybe something like:
node {node args} --run <script> -- {script args} -- {wireit args}
Member
Author
There was a problem hiding this comment.
Good idea, added general forms for npm and node --run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the new
node --runfeature which is available starting in Node 22 (basicallynpm runbut faster, see https://nodejs.org/en/blog/announcements/v22-release-announce#running-packagejson-scripts and https://www.yagiz.co/developing-fast-builtin-task-runner/).Note that
node --runis stricter than the other runners when it comes to distinguishing between arguments for the runner vs the script, so an additional--is needed to set wireit flags and script flags (explained in the README).Thank you very much to @anonrig for adding the environment variables this required (nodejs/node#53032, nodejs/node#53058) and @justinfagnani for filing the issue (nodejs/node#52673)!
There is a problem with recursive invocations on Windows that I believe is a Node bug but need to double-check, tracking at #1168.
Fixes #1094
Reviewer: the "Refactor tests a bit" commit is pretty noisy, but you can take my word it's a no-op :)