Skip to content
This repository was archived by the owner on Mar 1, 2022. It is now read-only.

Creating aspect option (ALL, CODE, PACKAGE)#475

Merged
garrettjonesgoogle merged 2 commits intogoogleapis:masterfrom
garrettjonesgoogle:master
Jul 26, 2018
Merged

Creating aspect option (ALL, CODE, PACKAGE)#475
garrettjonesgoogle merged 2 commits intogoogleapis:masterfrom
garrettjonesgoogle:master

Conversation

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle commented Jul 25, 2018

This will only work for C# so far; after googleapis/gapic-generator#2166 , it will work for Java too.

@garrettjonesgoogle garrettjonesgoogle mentioned this pull request Jul 25, 2018
Merged
vam-google
vam-google reviewed Jul 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general looks good, with several comments.

Comment thread artman/pipelines/grpc_generation.py Outdated
return task_utils.instantiate_tasks(tasks, kwargs)

def get_grpc_codegen_tasks(self, **kwargs):
if self.language == 'java':

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread artman/cli/main.py
help='[Required] Name of the artifact for artman to generate. Must '
'match an artifact in the artman config yaml.')
parser_generate.add_argument(
'--aspect',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread artman/tasks/gapic_tasks.py
args = args + gapic_args

gapic_artifact = ''
if aspect == 'ALL':

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment thread artman/config/loader.py


def load_artifact_config(artman_config_path, artifact_name):
def load_artifact_config(artman_config_path, artifact_name, aspect=None):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

vam-google
vam-google approved these changes Jul 25, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I still don't like the huge get_grpc_codegen_tasks method.

Comment thread artman/cli/main.py
help='[Required] Name of the artifact for artman to generate. Must '
'match an artifact in the artman config yaml.')
parser_generate.add_argument(
'--aspect',

This comment was marked as spam.

Sign in to view

Comment thread artman/pipelines/grpc_generation.py Outdated
return task_utils.instantiate_tasks(tasks, kwargs)

def get_grpc_codegen_tasks(self, **kwargs):
if self.language == 'java':

This comment was marked as spam.

Sign in to view

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor Author

garrettjonesgoogle commented Jul 25, 2018

ALL vs CODE_AND_PACKAGE: I considered the second, but I wanted to allow for adding a third item, and the default should be to include everything I think.

@garrettjonesgoogle
Copy link
Copy Markdown
Contributor Author

garrettjonesgoogle commented Jul 25, 2018

I split apart the long function, PTAL

@garrettjonesgoogle garrettjonesgoogle merged commit 8662dfe into googleapis:master Jul 26, 2018
@alexander-fenster alexander-fenster mentioned this pull request Jul 26, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@vam-google vam-google vam-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@garrettjonesgoogle @vam-google