Skip to content

[WIP] make smoke test a test and an app#3006

Closed
neozwu wants to merge 1 commit intogoogleapis:masterfrom
neozwu:smoke-test-demo
Closed

[WIP] make smoke test a test and an app#3006
neozwu wants to merge 1 commit intogoogleapis:masterfrom
neozwu:smoke-test-demo

Conversation

@neozwu
Copy link
Copy Markdown
Contributor

@neozwu neozwu commented Mar 7, 2018

Redesign autogenerated smoke test so that it has a "test entry point" and an "app entry point". Therefore, each smoke test can be run separately as a sample app (say, for debugging purpose). Or, all smoke tests can be run using mvn. ("mvn verify -P smoke-test"). For clients that require project-id, project-id can be detected through system property or environment variable. If app entry point is used, one can also pass project id through command line.

@neozwu neozwu added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 7, 2018
@neozwu neozwu requested a review from pongad as a code owner March 7, 2018 00:04
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 7, 2018
Copy link
Copy Markdown
Contributor

@garrettjonesgoogle garrettjonesgoogle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

@@ -0,0 +1,21 @@
/*
* Copyright 2016 Google LLC

This comment was marked as spam.

@neozwu
Copy link
Copy Markdown
Contributor Author

neozwu commented Mar 26, 2018

Close this PR since the function is implemented in separate PRs.

@neozwu neozwu closed this Mar 26, 2018
chingor13 pushed a commit that referenced this pull request Feb 20, 2026
Co-authored-by: Phong Chuong <147636638+PhongChuong@users.noreply.github.com>
suztomo pushed a commit that referenced this pull request Mar 9, 2026
* feat: Add Routine DataGovernanceType

This also:
- fix an issue where RoutineInfo unit test was being skipped
- fix an issue where ImportLibaries were not being exported in the toPb method

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix: Add DataGovernanceType to clirr ignored difference

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request Mar 20, 2026
Co-authored-by: Phong Chuong <147636638+PhongChuong@users.noreply.github.com>
chingor13 pushed a commit that referenced this pull request Mar 30, 2026
…ing HTTP Transport (#3006)

If a generation is present in the provided BlobInfo ensure it is sent to GCS. This is
a hard requirement when using versioned buckets and trying to update a non-current
object version.

Effects all version 2.42.0 through 2.50.0

Regression introduced in #2664

Fixes #2980
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants