Skip to content

[DO NOT MERGE] Removing doclint disabling for bigtable on Java 8 #3462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garrettjonesgoogle wants to merge 3 commits into from
Closed

[DO NOT MERGE] Removing doclint disabling for bigtable on Java 8 #3462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c4cbae6
Removing doclint disabling for bigtable on Java 8
garrettjonesgoogle Jul 12, 2018
b549e94
Introducing javadoc error
garrettjonesgoogle Jul 12, 2018
54c1efc
Printing maven version
garrettjonesgoogle Jul 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,9 @@ jobs:
<<: *anchor_docker
steps:
- checkout
- run:
name: print maven version
command: mvn --version
- run:
<<: *anchor_build
- run:
Expand Down
12 changes: 0 additions & 12 deletions google-cloud-clients/google-cloud-bigtable/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,18 +97,6 @@
<scope>test</scope>
</dependency>
</dependencies>
<profiles>
<profile>
<id>doclint-java8-disable</id>
<activation>
<jdk>[1.8,)</jdk>
</activation>
<properties>
<!-- add this to disable checking -->
<javadoc.opts>-Xdoclint:none</javadoc.opts>
</properties>
</profile>
</profiles>
<build>
<plugins>
<plugin>
Expand Down
2 changes: 1 addition & 1 deletion ...gle-cloud-bigtable/src/main/java/com/google/cloud/bigtable/admin/v2/TableAdminClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ public Table createTable(CreateTable createTable) {
* }</pre>
*
* @param createTable
* @return the newly created table
* @return ApiFuture<Table> the newly created table
* @see CreateTable for createTable configurations
*/
public ApiFuture<Table> createTableAsync(CreateTable createTable) {
Expand Down