Skip to content

pubsub: document auto message extension #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pongad merged 2 commits into from
Jul 25, 2018
Merged

pubsub: document auto message extension #3491

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33db727
pubsub: document auto message extension
pongad Jul 20, 2018
fd2c3d8
revert CI change
pongad Jul 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ jobs:
<<: *anchor_build
- run:
name: Run mvn javadoc goal
command: mvn javadoc:jar javadoc:test-jar
command: mvn javadoc:javadoc javadoc:test-javadoc

workflows:
version: 2
Expand Down
4 changes: 2 additions & 2 deletions ...loud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/Subscriber.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
*
* <p>The subscriber handles the ack management, by automatically extending the ack deadline while
* the message is being processed, to then issue the ack or nack of such message when the processing
* is done. <strong>Note:</strong> message redelivery is still possible.
* is done (see {@link Builder#setMaxAckExtensionPeriod(Duration)}). <strong>Note:</strong> message redelivery is still possible.
*
* <p>It also provides customizable options that control:
*
Expand Down Expand Up @@ -547,7 +547,7 @@ Builder setAckExpirationPadding(Duration ackExpirationPadding) {
}

/**
* Set the maximum period a message ack deadline will be extended.
* Set the maximum period a message ack deadline will be extended. Defaults to one hour.
*
* <p>It is recommended to set this value to a reasonable upper bound of the subscriber time to
* process any message. This maximum period avoids messages to be <i>locked</i> by a subscriber
Expand Down