Skip to content

Added explicit decencies for surefile-junit4 in order to fix testing in offline mode. #3820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JesseLovelace merged 19 commits into from
Oct 29, 2018
Merged

Added explicit decencies for surefile-junit4 in order to fix testing in offline mode. #3820

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
3122a61
Added explicit sunfire-junit depency to pull it in for offline mode.
Oct 10, 2018
1ada94d
Merge branch 'master' of github.com:/googleapis/google-cloud-java
Oct 11, 2018
fa627dc
Adding Surefire depency to bigtable admin and logging as well.
Oct 15, 2018
6ca9219
Merge branch 'master' into master
silverdev Oct 15, 2018
6070e68
Looks like I need to tell the plugin that it's using the version I'm …
Oct 17, 2018
1f0b47f
Looks like the Google Cloud Java Compatibility Checker test require s…
Oct 18, 2018
ba1f318
dependecies is not under build.
Oct 18, 2018
30fb767
Some of the GRPC library need dependencies need surefire 2.17
silverdev Oct 18, 2018
baade24
Looks like the file path is org.apache.maven.plugins
silverdev Oct 18, 2018
d97a8c1
Merge branch 'master' of github.com:/googleapis/google-cloud-java
Oct 18, 2018
0b2a926
Merge branch 'master' of github.com:silverdev/google-cloud-java
Oct 18, 2018
acd321c
lets try putting the in utils. It looks like utill uses surefire 2.17
Oct 18, 2018
59b92e7
Merge branch 'master' of github.com:/googleapis/google-cloud-java
Oct 22, 2018
bc184f7
Looks like spanner uses surefire-junit47 instead of surefire-junit4
Oct 23, 2018
39537b2
Re-add bigtable admin version
Oct 24, 2018
0c08759
Merge branch 'master' of github.com:/googleapis/google-cloud-java
Oct 24, 2018
4efa653
Lets not include spanner with this PR.
Oct 24, 2018
e4202d1
Merge branch 'master' into master
JesseLovelace Oct 25, 2018
aa10068
Merge branch 'master' into master
JesseLovelace Oct 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions google-cloud-clients/google-cloud-bigtable-admin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,11 @@
<artifactId>grpc-testing</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-junit4</artifactId>
<version>2.19.1</version>
</dependency>
</dependencies>
<profiles>
<profile>
Expand Down
12 changes: 12 additions & 0 deletions google-cloud-clients/google-cloud-bigtable/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,11 @@
<artifactId>grpc-testing</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-junit4</artifactId>
<version>2.19.1</version>
</dependency>
</dependencies>
<profiles>
<profile>
Expand Down Expand Up @@ -128,6 +133,13 @@
<perCoreThreadCount>true</perCoreThreadCount>
<threadCount>2</threadCount>
</configuration>
<dependencies>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-junit4</artifactId>
<version>2.19.1</version>
</dependency>
</dependencies>
</plugin>
</plugins>
</build>
Expand Down
5 changes: 5 additions & 0 deletions google-cloud-clients/google-cloud-logging/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,10 @@
<classifier>testlib</classifier>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-junit4</artifactId>
<version>2.19.1</version>
</dependency>
</dependencies>
</project>
12 changes: 12 additions & 0 deletions google-cloud-clients/google-cloud-spanner/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,13 @@
<skipTests>${skipUnitTests}</skipTests>
<reportNameSuffix>sponge_log</reportNameSuffix>
</configuration>
<dependencies>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-junit4</artifactId>
<version>2.12.4</version>
</dependency>
</dependencies>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down Expand Up @@ -191,5 +198,10 @@
<artifactId>json</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.maven.surefire</groupId>
<artifactId>surefire-junit4</artifactId>
<version>2.12.4</version>

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

</dependency>
</dependencies>
</project>