Skip to content

Fixes cleanup issues#3874

Merged
chingor13 merged 2 commits intogoogleapis:masterfrom
pmakani:cleanup_fix
Oct 31, 2018
Merged

Fixes cleanup issues#3874
chingor13 merged 2 commits intogoogleapis:masterfrom
pmakani:cleanup_fix

Conversation

@pmakani
Copy link
Copy Markdown

@pmakani pmakani commented Oct 30, 2018

Fixes

#3707 test-jar in google-cloud-bom.

#3728 Don't bundle tests in jars.

@pmakani pmakani requested a review from a team October 30, 2018 11:32
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2018
@sduskis
Copy link
Copy Markdown
Contributor

sduskis commented Oct 31, 2018

@chingor13, do you have any issues with this? @elharo, does this look right to you?

@sduskis sduskis added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 31, 2018
@chingor13 chingor13 merged commit bff49f9 into googleapis:master Oct 31, 2018
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
…iptors (#3874)

See b/416626151 for more information.

Problem: When the sampledToLocalTracing is set to false or not set, the
gRPC specific metrics have the `grpc.method` attribute defined as
`other` instead of the methodDescriptor's full name. This may be
confusing to customers who may expect to see the full gRPC method name.

High Level: This flag enables captures for specific method names to help
provide more detailed metrics. We do not expect any noticeable
performance impact from this change.

This does not impact the method name that is already properly captured
for Gax Metrics (e.g. Attempt Count, Operation Latency, etc).
Specifically, the use must be using grpc-java telemetry module and be
using
[GrpcOpenTelemetry](https://grpc.github.io/grpc-java/javadoc/io/grpc/opentelemetry/GrpcOpenTelemetry.html)
instead of
[OpenTelemetry](https://github.com/open-telemetry/opentelemetry-java/blob/main/api/all/src/main/java/io/opentelemetry/api/OpenTelemetry.java).

---------

Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>
chingor13 pushed a commit that referenced this pull request Mar 24, 2026
🤖 I have created a release *beep* *boop*
---


<details><summary>2.62.0</summary>

##
[2.62.0](googleapis/sdk-platform-java@v2.61.0...v2.62.0)
(2025-08-19)


### Features

* Set sampledToLocalTracing flag to true for all gRPC MethodDescriptors
([#3874](googleapis/sdk-platform-java#3874))
([f0f520a](googleapis/sdk-platform-java@f0f520a))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants