Create new google-cloud-conformance-tests module#5537
Closed
BenWhitehead wants to merge 1 commit intogoogleapis:masterfrom
BenWhitehead:firestore-conformance-tests-json
Closed
Create new google-cloud-conformance-tests module#5537BenWhitehead wants to merge 1 commit intogoogleapis:masterfrom BenWhitehead:firestore-conformance-tests-json
BenWhitehead wants to merge 1 commit intogoogleapis:masterfrom
BenWhitehead:firestore-conformance-tests-json
Conversation
A new module where common code related to conformance tests can be
shared.
* Includes a rudimentary classpath scanner that can be used to locate
test definitions. (The firestore test suite currently have 224 test
definitions.)
* The classpath scanner includes a suite of tests to ensure it can
accurately find resources in jar files and directories.
* Tests have been ran against the following JVMs on Linux x64 and
verified to pass.
```
openjdk version "1.7.0_75"
OpenJDK Runtime Environment (build 1.7.0_75-b13)
OpenJDK 64-Bit Server VM (build 24.75-b04, mixed mode)
java version "1.8.0_201"
Java(TM) SE Runtime Environment (build 1.8.0_201-b09)
Java HotSpot(TM) 64-Bit Server VM (build 25.201-b09, mixed mode)
java version "11.0.2" 2019-01-15 LTS
Java(TM) SE Runtime Environment 18.9 (build 11.0.2+9-LTS)
Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.2+9-LTS, mixed mode)
openjdk version "12" 2019-03-19
OpenJDK Runtime Environment (build 12+33)
OpenJDK 64-Bit Server VM (build 12+33, mixed mode, sharing)
```
* Add new script generate-conformance-tests.sh that can reliably update
the various files that make up the conformance tests.
* Currently the script only updates firestore tests, but will be
updated for the other projects in a later commit.
* Updating of the git-submodule linking to conformance tests is not
done by the script, it is expected that the developer will do the
bumping.
Bump firestore conformance tests to googleapis/conformance-tests@5a98470
* import proto definition
* generate updated TestDefinition from definition
* Add individual test files
* Add dependency from `com.google.cloud:google-cloud-firestore` -> `com.google.cloud:google-cloud-conformance-tests`
* Move proto inclusion from `com.google.cloud:google-cloud-firestore`/tests to `com.google.cloud:google-cloud-conformance-tests`/main
* Add maven profile `gen-conformance-protos` that can be used to generate protos in `com.google.cloud:google-cloud-conformance-tests`
googlebot
added
the
cla: yes
Contributor
Author
|
@kolea2 Please review when you get a chance |
Contributor
|
Can you split this up into two PRs? (the creation of the module, and then the changes to the tests) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new module where common code related to conformance tests can be
shared.
test definitions. (The firestore test suite currently have 224 test
definitions.)
accurately find resources in jar files and directories.
verified to pass.
the various files that make up the conformance tests.
updated for the other projects in a later commit.
done by the script, it is expected that the developer will do the
bumping.
Bump firestore conformance tests to googleapis/conformance-tests@5a98470
com.google.cloud:google-cloud-firestore->com.google.cloud:google-cloud-conformance-testscom.google.cloud:google-cloud-firestore/tests tocom.google.cloud:google-cloud-conformance-tests/maingen-conformance-protosthat can be used to generate protos incom.google.cloud:google-cloud-conformance-tests