add support for validation rules#83
Merged
jkimbo merged 5 commits intographql-python:masterfrom Aug 10, 2021
aryaniyaps:master
Merged
add support for validation rules#83jkimbo merged 5 commits intographql-python:masterfrom aryaniyaps:master
jkimbo merged 5 commits intographql-python:masterfrom
aryaniyaps:master
Conversation
(commited by mistake. updated .gitignore)
Contributor
Author
|
oops, committed venv by mistake. Updated .gitignore and removed the dir. |
jkimbo
reviewed
Aug 9, 2021
| return self.middleware | ||
|
|
||
| def get_validation_rules(self): | ||
| return self.validation_rules |
Member
There was a problem hiding this comment.
This should return the default validation rules if validation_rules is None:
from graphql import specified_rules
jkimbo
previously approved these changes
Aug 9, 2021
Contributor
Author
|
When would this be merged?🤔 |
Member
|
@CodeByAryan I just merged #84 Could you bring this branch up to date? |
Contributor
Author
|
@jkimbo done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allows passing validation rules as an argument to the graphqlview.
also updated docs regarding the same. fixes #82