Change: Extend invalid URL plugin and relevant tests.#764
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. OpenSSF Scorecard
Scanned Manifest Files |
Conventional Commits Report
🚀 Conventional commits found. |
2a0b081 to
0de9da4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
+ Coverage 79.53% 79.69% +0.15%
==========================================
Files 87 87
Lines 2986 3009 +23
Branches 577 584 +7
==========================================
+ Hits 2375 2398 +23
Misses 462 462
Partials 149 149 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@greenbone/troubadix-maintainers Ready for a first review and (improvement) suggestions always welcome. |
c7af1b2 to
5fc48a1
Compare
n-thumann
requested changes
Oct 25, 2024
bbb029c to
306a571
Compare
306a571 to
0ff1791
Compare
n-thumann
approved these changes
Oct 28, 2024
Member
|
Forgot to mention this in the review: I ran this plugin against |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
References
None
Checklist