Adds platform path handling to sandbox file imports#2064
Merged
Conversation
paulfitz
approved these changes
Jan 22, 2026
|
|
||
| # Parse the incoming path using the appropriate pathlib class | ||
| if path_flavor == "windows": | ||
| incoming_path = PureWindowsPath(file_source_path) |
Member
There was a problem hiding this comment.
Looks to be okay to use in python versions >= about 3.4 so all the python versions we care about. Good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Pyodide's sandbox security was improved by changing it to copy import folders into the sandbox, rather than mounting the host's filesystem directly.
This resulted in Grist's file imports breaking on Windows, due to the Pyodide sandbox using POSIX-style paths and the Grist node process using Windows-style paths.
The node process would produce import paths similar to
my_temp_dir\my_file_to_import.csv, which Pyodide would interpret as a file name (rather than a directory and a file).Proposed solution
This adds "pathFlavor" to the FileSource object passed to the sandbox, describing if the path is Windows or POSIX formatted. This allows the sandbox to parse and re-format the path as needed for the sandbox's filesystem.
Related issues
gristlabs/grist-desktop#101
Has this been tested?
This fix has been tested on Windows with a custom Grist Desktop build, but not automatically as core doesn't have any Windows test runners configured.