fix suggestions on documents with deleted tables#2069
Merged
Conversation
If tables have been deleted from a document, it looks like rowModels can exist but be empty. This led to an error in suggestions.
berhalak
approved these changes
Jan 26, 2026
| const lst = Object.entries(diffs).map(([table, tdiff]: [string, TabularDiff]) => { | ||
| const data = convertTabularDiffToTableData(table, tdiff); | ||
| const tableRow = this._gristDoc.docModel.tables.rowModels.find(tr => tr.tableId() === table); | ||
| // Careful, there can be blank rowModels if tables were removed. |
Contributor
There was a problem hiding this comment.
Funny how GitHub sees this one-character change as a big two-line modification 😞
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If tables have been deleted from a document, it looks like rowModels can exist but be empty. This led to an error in suggestions.
Has this been tested?