Fixing width issue and scrollbar issue on suggestions on mac#2075
Merged
Fixing width issue and scrollbar issue on suggestions on mac#2075
Conversation
berhalak
changed the title
berhalak
force-pushed
the
jareks/better-scrollbars-on-suggestions
branch
from
b9d80d2 to
ce0badf
Compare
Contributor
Author
|
Preview from cloned PR, as this branch name is too long to create the preview. https://grist-gristlabs-grist-core-jareks-suggestion-css.fly.dev/ |
paulfitz
reviewed
Jan 28, 2026
| function scrollBar(): { width: number; height: number } { | ||
| // Currently this feature is limited to suggestions only in virtual tables, that are showing | ||
| // inline grids. For this sake we can assume that scrollbars are always visible and have | ||
| // standard width/height across all browsers. |
Member
There was a problem hiding this comment.
How does this reconcile with the comment "Scrollbars have different widths on different platforms"?
Do you mean that although there could be differences, the numbers here work ok for the browsers you tested and for the particular use made of this feature?
Contributor
Author
There was a problem hiding this comment.
Yes, exactly. I tested on those 6 platforms and this gives enough space on all of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Virtual tables weren't rendered properly on mac where the scrollbars have different sizes.
Proposed solution
Has this been tested?
Manual tests only
Screenshots / Screencasts