grpc-js-core: prevent callback before 'end' event and handle eos headers as trailers#132
Merged
kjin merged 2 commits intogrpc:masterfrom Jan 9, 2018
Merged
grpc-js-core: prevent callback before 'end' event and handle eos headers as trailers#132kjin merged 2 commits intogrpc:masterfrom
kjin merged 2 commits intogrpc:masterfrom
Conversation
ef616c3 to
ad8eef0
Compare
ad8eef0 to
22438ae
Compare
Contributor
Author
|
Just to summarize what we talked about earlier in person -- there are three new
We decided that 1 & 2 are necessary. For 3 I believe this is also necessary because we don't want trailing metadata to be ignored in a race condition where FYI, I made two more changes:
|
murgatroid99
approved these changes
Jan 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grpc-js-core: in unary calls, don't invoke callback before end eventFor unary response calls,
'status'might be emitted too soon, and the user won't see any data in their callback. This change ensures that if'statuscomes before'end', that'end'will invoke the user callback instead.grpc-js-core: handle eos headers as trailersWe should treat headers with
END_STREAMflags as if they were trailers. In addition, I've added code to prevent race conditions for emitted StatusObject instances: if a header or trailer (in that order of priority) is still being put through the filter stack, wait to give those execution threads an opportunity to end the call first, before allowing the call to be ended synchronously in astreamClosedevent.