Skip to content

feat: allow returning root_password in servers rebuild#276

Merged
jooola merged 1 commit intohetznercloud:mainfrom
jooola:server_rebuild_password
Nov 17, 2023
Merged

feat: allow returning root_password in servers rebuild#276
jooola merged 1 commit intohetznercloud:mainfrom
jooola:server_rebuild_password

Conversation

@jooola
Copy link
Member

@jooola jooola commented Aug 7, 2023

Fixes #181

Allow returning a full response during the server rebuild by passing an option to the rebuild method. The main reason for this is to not break user land and give users time to upgrade. We also don't want to introduce a new method rebuild2 or rebuild_with_full_response to keep the API clean.

The deprecation timeline is the following:

  • Introduce the return_response argument and deprecated the default behavior (return_response=False)
  • Wait for the next major release to remove the ability to only return the action and deprecated the usage of the return_response argument.
  • Wait for the next+1 major release to fully remove the return_response argument, or simply leave it unused.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rebuild does not return root_password

2 participants