Draft
Conversation
wip: copy parcel to vite wip: add __vite_rsc_preload__ and __vite_rsc_require__ wip: more rename wip: dev only wip: rename wip: remove parcelRequire wip: build prod wip: move findSourceMapURL to client option chore: comment chore: use __vite_rsc_preload__ only wip: fix findSourceMapURL wip: add fixtures/flight-vite wip: build fix: ssr client reference modulepreload wip: add setPreloadModule API refactor: abstract runtime wip: rename createClientReference to registerClientReference like webpack wip: tweak createServerReference refactor: remove unused wip: remove setServerCallback and align with webpack chore: comment chore: rename parcel to vite chore: prettier chore: lint chore: fix flow fix: global async reference cache wip: add ClientManifest type chore: lint chore: add css example wip: remove caching chore: add suspense example chore: rename mini to basic chore: fix streaming in vite preview feat: support prepare destination chore: cleanup test: tweak feat: add findSourceMapURL test: tweak fixture chore: cleanup test: normalize reference key chore: fix actions imported from client + preserve `createServerReference` position chore: temporary references chore: use `@hiogawa/transforms` in fixture chore: test temporary reference + early hydration chore: move code chore: test nonce in fixtures chore: fix deps chore: comment fix: allow unsafe-eval during dev for `createFakeFunction` chore: add inline action chore: copy transform utils to fixture chore: comment and readme
|
Is this being built and published as a package presently? Would love to give it a try in vinxi and see if we can get this tooling to provide server components support in vinxi too! |
Owner
Author
|
@nksaraf Hey, thanks for the interest! The branch is fairly recent (about a week old from main branch) and the package is published on pkg.pr.new #2. You can find a link in https://github.com/hi-ogawa/react/runs/43510765383. |
5 tasks
21 tasks
hi-ogawa
pushed a commit
that referenced
this pull request
Jul 18, 2025
…paces (facebook#33409) ## Summary Problem #1: Running the `link-compiler.sh` bash script via `"prebuild"` script fails if a developer has cloned the `react` repo into a folder that contains _any_ spaces. 3 tests fail because of this. <img width="1003" alt="fail-1" src="https://github.com/user-attachments/assets/1fbfa9ce-4f84-48d7-b49c-b6e967b8c7ca" /> <img width="1011" alt="fail-2" src="https://github.com/user-attachments/assets/0a8c6371-a2df-4276-af98-38f4784cf0da" /> <img width="1027" alt="fail-3" src="https://github.com/user-attachments/assets/1c4f4429-800c-4b44-b3da-a59ac85a16b9" /> For example, my current folder is: `/Users/wes/Development/Open Source Contributions/react` The link compiler error returns: `./scripts/react-compiler/link-compiler.sh: line 15: cd: /Users/wes/Development/Open: No such file or directory` Problem #2: 1 test in `ReactChildren-test.js` fails due the existing stack trace regex which should be lightly revised. `([^(\[\n]+)[^\n]*/g` is more robust for stack traces: it captures the function/class name (with dots) and does not break on spaces in file paths. `([\S]+)[^\n]*/g` is simpler but breaks if there are spaces and doesn't handle dotted names well. Additionally, we trim the whitespace off the name to resolve extra spaces breaking this test as well: ``` - in div (at **) + in div (at **) ``` <img width="987" alt="fail-4" src="https://github.com/user-attachments/assets/56a673bc-513f-4458-95b2-224129c77144" /> All of the above tests pass if I hyphenate my local folder: `/Users/wes/Development/Open-Source-Contributions/react` I selfishly want to keep spaces in my folder names. 🫣 ## How did you test this change? **npx yarn prebuild** Before: <img width="896" alt="Screenshot at Jun 01 11-42-56" src="https://github.com/user-attachments/assets/4692775c-1e5c-4851-9bd7-e12ed5455e47" /> After: <img width="420" alt="Screenshot at Jun 01 11-43-42" src="https://github.com/user-attachments/assets/4e303c00-02b7-4540-ba19-927b2d7034fb" /> **npx yarn test** **npx yarn test ./packages/react/src/\_\_tests\_\_/ReactChildren-test.js** **npx yarn test -r=xplat --env=development --variant=true --ci --shard=3/5** Before: <img width="438" alt="before" src="https://github.com/user-attachments/assets/f5eedb22-18c3-4124-a04b-daa95c0f7652" /> After: <img width="439" alt="after" src="https://github.com/user-attachments/assets/a94218ba-7c6a-4f08-85d3-57540e9d0029" /> <img width="650" alt="Screenshot at Jun 02 18-03-39" src="https://github.com/user-attachments/assets/3eae993c-a56b-46c8-ae02-d249cb053fe7" /> <img width="685" alt="Screenshot at Jun 03 12-53-47" src="https://github.com/user-attachments/assets/5b2caa33-d3dc-4804-981d-52cb10b6226f" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a last resort, we should publish a package as fork.