Fix additional test cases for Python 3.12#101006
Merged
cdce8p merged 1 commit intohome-assistant:devfrom Sep 27, 2023
Merged
Conversation
Contributor
|
Hey there @home-assistant/supervisor, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
emontnemery
reviewed
Sep 27, 2023
emontnemery
approved these changes
Sep 27, 2023
Contributor
emontnemery
left a comment
There was a problem hiding this comment.
LGTM, thanks @cdce8p 👍
32 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix some additional test cases to be compatible with Python 3.12.
These changes are necessary due to subtle behavior changes in CPython. Some might consider them breaking changes, however it was argued that the current implementation was jank / broken, so these should be considered bug fixes.
For the
hassiotest, it's a change of theasyncio.Server.wait_closedbehavior which is used byaiohttpThe script tests, a small refactor in
asyncio.wait_forasyncio.wait_forto useasyncio.timeoutpython/cpython#98518Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: