Conversation
Summary of ChangesHello @garrett4wade, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly refactors the project's code formatting and linting setup by migrating from a multi-tool approach (autoflake, isort, black) to a unified solution using Ruff. The change aims to simplify the development workflow, reduce configuration overhead, and improve performance by leveraging Ruff's comprehensive capabilities. Additionally, several legacy configuration files have been removed, contributing to a cleaner and more maintainable project structure. The adoption of Ruff will be gradual to manage potential large-scale formatting changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request is a great initiative to consolidate the Python linting and formatting toolchain by adopting ruff. The removal of unused configuration files like Makefile and setup.py also helps to clean up the repository. My review has identified a few critical issues related to an invalid ruff version being specified across multiple configuration files, which will break the build and pre-commit hooks. I've also found a misconfiguration in the pre-commit setup that would prevent ruff from running on any files. Additionally, I've suggested a way to preserve the pytest configuration that was removed. Addressing these points will ensure a smooth transition to the new tooling.
Description
Update code formatting to use
ruff. Ruff provides broader functionality thanisort,black, andautoflakecombined, consolidating our formatting toolchain.Related Issue
N/A
Type of Change
Checklist
jb build docs/gemini review)Breaking Change Details (if applicable):
While
ruffshould not conflict with CI formatting checks, it introduces formatting rules that may significantly alter existing formatted code. To avoid a large-scale code change in this PR, we are not runningpre-commit run --all-filesat this time. Instead, we plan to gradually update the codebase as files are modified in future changes.Additional Context
N/A