Conversation
Summary of ChangesHello @HwVanICI, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for training Vision-Language Models (VLMs) on Neural Processing Units (NPUs). It addresses the current gap in official documentation and examples for NPU-based VLM training within the AReaL framework, making it significantly easier for users to implement, debug, and reproduce VLM training on NPU devices. The changes include a new example directory with scripts, configuration, and detailed documentation, along with benchmark results showcasing NPU performance. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable example for training Vision-Language Models (VLMs) on NPUs, which is a great addition to the repository. The implementation is solid, but I've identified a few areas for improvement to enhance code quality, maintainability, and correctness. My review includes suggestions for fixing a critical typo in a shell script, improving performance and readability in the Python script by addressing a magic number and pre-compiling a regex, and correcting minor formatting issues and typos in the documentation. Overall, these changes will make the new example more robust and easier to understand.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
garrett4wade
left a comment
There was a problem hiding this comment.
LGTM except for a minor issue.
Description
AReaL currently provides VLM training examples only for GPU devices. There is no official documentation or example demonstrating how to train VLMs on NPU (e.g., Ascend) using AReaL and vllm-ascend. This makes NPU usage harder to adopt, debug, and reproduce.
Related Issue
Fixes #(issue)
Type of Change
work as expected)
Checklist
jb build docs/gemini review)Proposed Solution
Add a new example directory:
This folder will provide:
Results:
We trained Qwen2.5-VL-3B for 70 epochs on Geometry3K and evaluated the checkpoints using VLMEvalKit on out of distribution tasks such as MathVision, MathVista, and LogicVista. The training was performed on both NPU and GPU and results are as follows: