Skip to content

testing: fix CI, skip tests that cannot run on A100 GPUs#838

Merged
garrett4wade merged 4 commits intomainfrom
mzy/skip-archon-tests
Jan 20, 2026
Merged

testing: fix CI, skip tests that cannot run on A100 GPUs#838
garrett4wade merged 4 commits intomainfrom
mzy/skip-archon-tests

Conversation

@nuzant
Copy link
Copy Markdown
Collaborator

@nuzant nuzant commented Jan 20, 2026

Description

Related Issue

Fixes #(issue)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not
    work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement

Checklist

  • I have read the Contributing Guide
  • I have run formatting tools (pre-commit or manual)
  • I have run relevant unit tests and they pass
  • I have added tests for new functionality
  • I have updated documentation if needed
  • My branch is up to date with main
  • This PR introduces breaking changes (if yes, fill out details below)
  • If this PR changes documentation, I have built and previewed it locally with
    jb build docs
  • No critical issues raised by AI reviewers (/gemini review)

Breaking Change Details (if applicable):

Additional Context


Need help? Check the Contributing Guide or ask in
GitHub Discussions!

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @nuzant, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the continuous integration pipeline's stability by implementing conditional test skipping. It ensures that tests requiring specific GPU hardware, such as those with CUDA compute capability 9.0 (like A100 GPUs), are only executed when the necessary hardware is present. This prevents test failures in environments that do not meet these hardware requirements, leading to a more reliable and efficient CI process.

Highlights

  • Conditional Test Skipping: Introduced logic to conditionally skip tests in test_grouped_experts.py based on CUDA availability and GPU compute capability.
  • GPU Hardware Requirement: Tests will now be skipped if CUDA is not available or if the current CUDA device's compute capability is not exactly 9.0 (e.g., A100 GPUs).
  • CI Stability Improvement: This change aims to fix CI failures by preventing tests from running on environments that lack the specific GPU hardware required for their execution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix CI by skipping tests that are not compatible with A100 GPUs. The change involves adding a module-level pytest.mark.skipif to areal/tests/experimental/archon/test_grouped_experts.py to run these tests only on devices with CUDA compute capability 9.0. My review focuses on improving the readability of the new logic and suggests considering a more flexible check for future GPU architectures.

Comment thread areal/tests/experimental/archon/test_grouped_experts.py Outdated
@nuzant nuzant added the safe-to-test Ready to run unit-tests in a PR. label Jan 20, 2026
@nuzant nuzant force-pushed the mzy/skip-archon-tests branch from fcec72c to 047bd05 Compare January 20, 2026 09:56
@nuzant nuzant added safe-to-test Ready to run unit-tests in a PR. and removed safe-to-test Ready to run unit-tests in a PR. labels Jan 20, 2026
@nuzant nuzant temporarily deployed to AReaL-unittests January 20, 2026 10:03 — with GitHub Actions Inactive
Copy link
Copy Markdown
Collaborator

@rchardx rchardx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guud. Waiting for CI.

@rchardx rchardx added safe-to-test Ready to run unit-tests in a PR. and removed safe-to-test Ready to run unit-tests in a PR. labels Jan 20, 2026
@rchardx rchardx temporarily deployed to AReaL-unittests January 20, 2026 11:40 — with GitHub Actions Inactive
@garrett4wade garrett4wade merged commit e18f84d into main Jan 20, 2026
7 checks passed
@garrett4wade garrett4wade deleted the mzy/skip-archon-tests branch January 20, 2026 13:57
leandermaben pushed a commit to leandermaben/AReaL that referenced this pull request Mar 24, 2026
…#838)

* skip grouped mm tests

* Leave notes for fixes

---------

Co-authored-by: Wentai Zhang <zhangwentai.zwt@antgroup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe-to-test Ready to run unit-tests in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants