testing: fix CI, skip tests that cannot run on A100 GPUs#838
testing: fix CI, skip tests that cannot run on A100 GPUs#838garrett4wade merged 4 commits intomainfrom
Conversation
Summary of ChangesHello @nuzant, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the continuous integration pipeline's stability by implementing conditional test skipping. It ensures that tests requiring specific GPU hardware, such as those with CUDA compute capability 9.0 (like A100 GPUs), are only executed when the necessary hardware is present. This prevents test failures in environments that do not meet these hardware requirements, leading to a more reliable and efficient CI process. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to fix CI by skipping tests that are not compatible with A100 GPUs. The change involves adding a module-level pytest.mark.skipif to areal/tests/experimental/archon/test_grouped_experts.py to run these tests only on devices with CUDA compute capability 9.0. My review focuses on improving the readability of the new logic and suggests considering a more flexible check for future GPU architectures.
fcec72c to
047bd05
Compare
…#838) * skip grouped mm tests * Leave notes for fixes --------- Co-authored-by: Wentai Zhang <zhangwentai.zwt@antgroup.com>
Description
Related Issue
Fixes #(issue)
Type of Change
work as expected)
Checklist
jb build docs/gemini review)Breaking Change Details (if applicable):
Additional Context
Need help? Check the Contributing Guide or ask in
GitHub Discussions!