fix(openai-proxy): return None for empty trajectory in online mode#971
fix(openai-proxy): return None for empty trajectory in online mode#971garrett4wade merged 2 commits intomainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the OpenAI proxy's online mode by introducing robust handling for sessions that conclude without any user interactions. The change ensures that such empty sessions are gracefully managed, preventing potential system failures or the generation of misleading statistical data, thus improving the overall stability and accuracy of the proxy's operation. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue in the OpenAI proxy workflow's online mode where sessions with no interactions were not handled properly. The change introduces a check for empty interactions, logs a warning, and returns None to reject the trajectory, which aligns with the intended logic. This makes the workflow more robust. I have one minor suggestion to improve performance when retrieving the last interaction.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Description
Fix empty session handling in OpenAI proxy workflow's online mode. When a session has no interactions (user connected but never sent any chat/completions requests), the workflow now returns
Nonewith a warning instead of failing or producing incorrect stats.Related Issue
Fixes #(issue)
Type of Change
Checklist
jb build docs/gemini review)Breaking Change Details (if applicable):
N/A
Additional Context
Empty sessions in online mode could cause index errors or record incorrect stats. Now they are gracefully handled with a warning log and rejected trajectory.
Need help? Check the Contributing Guide or ask in
GitHub Discussions!