Skip to content

fix(openai-proxy): return None for empty trajectory in online mode#971

Merged
garrett4wade merged 2 commits intomainfrom
sxj/fix_openclaw
Mar 4, 2026
Merged

fix(openai-proxy): return None for empty trajectory in online mode#971
garrett4wade merged 2 commits intomainfrom
sxj/fix_openclaw

Conversation

@fishcrap
Copy link
Collaborator

@fishcrap fishcrap commented Mar 3, 2026

Description

Fix empty session handling in OpenAI proxy workflow's online mode. When a session has no interactions (user connected but never sent any chat/completions requests), the workflow now returns None with a warning instead of failing or producing incorrect stats.

Related Issue

Fixes #(issue)

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Code refactoring (no functional changes)
  • Performance improvement
  • Test coverage improvement

Checklist

  • I have read the Contributing Guide
  • I have run formatting tools (pre-commit or manual)
  • I have run relevant unit tests and they pass
  • I have added tests for new functionality
  • I have updated documentation if needed
  • My branch is up to date with main
  • This PR introduces breaking changes (if yes, fill out details below)
  • If this PR changes documentation, I have built and previewed it locally with jb build docs
  • No critical issues raised by AI reviewers (/gemini review)

Breaking Change Details (if applicable):

N/A

Additional Context

Empty sessions in online mode could cause index errors or record incorrect stats. Now they are gracefully handled with a warning log and rejected trajectory.


Need help? Check the Contributing Guide or ask in
GitHub Discussions!

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the OpenAI proxy's online mode by introducing robust handling for sessions that conclude without any user interactions. The change ensures that such empty sessions are gracefully managed, preventing potential system failures or the generation of misleading statistical data, thus improving the overall stability and accuracy of the proxy's operation.

Highlights

  • Empty Session Handling: Implemented explicit handling for sessions in the OpenAI proxy's online mode that have no user interactions, preventing errors and incorrect statistics.
  • Graceful Exit: The workflow now returns None and logs a warning when an empty session is detected, indicating that the trajectory will be rejected.
  • Refactored Stat Recording: Adjusted the logic for recording statistics to ensure it only proceeds when actual interactions are present in a session.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • areal/experimental/openai/proxy/workflow.py
    • Added a conditional check to detect sessions with no interactions.
    • Introduced a warning log message for empty sessions, indicating trajectory rejection.
    • Modified the function to return None immediately if no interactions are found.
    • Adjusted the stat recording logic to execute only when interactions are present, removing redundant checks.
Activity
  • No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses an issue in the OpenAI proxy workflow's online mode where sessions with no interactions were not handled properly. The change introduces a check for empty interactions, logs a warning, and returns None to reject the trajectory, which aligns with the intended logic. This makes the workflow more robust. I have one minor suggestion to improve performance when retrieving the last interaction.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@garrett4wade garrett4wade merged commit 8023695 into main Mar 4, 2026
5 checks passed
@garrett4wade garrett4wade deleted the sxj/fix_openclaw branch March 4, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants