Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jeswr
force-pushed
the
chore/test-webpacking
branch
from
d99001b to
a847705
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Contributor
|
@jeswr so since this was merged we dont need this PR anymore right? just a bump on readable-stream? |
Contributor
Author
|
@chelseapinka - this PR is for regression testing so we want to keep it and merge it. I tried running this branch on v4.4.1 of readable-stream but discovered this issue - I will try again shortly on 4.4.2 which was just released |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recently there was a regression in the NodeJS readable-stream package which required webpack configs to polyfill the
streampackage.This adds a test to make sure no such regressions are introduced into our codebase by
readable-streamor any other package in the future.This PR is blocked until nodejs/readable-stream#516 is resolved. I have proposed a fix upstream in nodejs/readable-stream#519.