refactor(collector): moved resolve string config to core utility#2479
Merged
aryamohanan merged 4 commits intofix-config-precedencefrom Apr 10, 2026
Merged
refactor(collector): moved resolve string config to core utility#2479aryamohanan merged 4 commits intofix-config-precedencefrom
aryamohanan merged 4 commits intofix-config-precedencefrom
Conversation
aryamohanan
changed the title
aryamohanan
changed the title
aryamohanan
commented
Apr 8, 2026
| */ | ||
| function normalizeAutoProfile(userConfig, defaultConfig) { | ||
| return resolveConfig(process.env.INSTANA_AUTO_PROFILE, userConfig.autoProfile, defaultConfig.autoProfile); | ||
| return util.resolveConfig({ |
Contributor
Author
There was a problem hiding this comment.
This was missed refactoring. Moved the resolve method to core util
aryamohanan
changed the title
kirrg001
reviewed
Apr 9, 2026
aryamohanan
commented
Apr 10, 2026
| [key: string]: any; | ||
| }; | ||
| autoProfile?: boolean | string; | ||
| autoProfile?: boolean; |
Contributor
Author
There was a problem hiding this comment.
autoProfile config expect true or fale and is always boolean. The type has been updated to boolean. The environment value parsing has also been handled.
aryamohanan
changed the title
|
aryamohanan
added a commit
that referenced
this pull request
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moved string resolve config to core utility