Skip to content

chore: upgrade Ruff configuration and reformat codebase#861

Open
pvital wants to merge 22 commits intomainfrom
ruff_update
Open

chore: upgrade Ruff configuration and reformat codebase#861
pvital wants to merge 22 commits intomainfrom
ruff_update

Conversation

@pvital
Copy link
Copy Markdown
Member

@pvital pvital commented Apr 7, 2026 •
edited
Loading

This PR modernizes the repository’s Ruff setup and applies the resulting formatting and lint cleanup across the codebase and tests.

  • Upgraded pre-commit Ruff integration in .pre-commit-config.yaml
    • bumped Ruff from v0.7.0 to v0.15.9
    • switched the lint hook from ruff to ruff-check
    • extended formatting hook coverage to Python and Markdown files
  • Added Ruff configuration to pyproject.toml
    • set Python target version to 3.9
    • configured repository exclusions for non-source directories
    • enabled preview mode and concise output
    • defined lint rule selection for style, import ordering, simplification, string modernizations, and copyright checks
  • Applied repository-wide Ruff-driven cleanup across source and test files
    • normalized import ordering
    • reformatted multiline logging, context managers, assertions, and long calls
    • simplified membership checks, such as key in dict instead of key in dict.keys()
    • removed unused imports in several tests
    • cleaned whitespace and newline issues
  • Fixed SonarQube failed conditions on new code
    • Deleted src/instana/util/gunicorn.py since the code is duplicated in running_in_gunicorn() function from src/instana/log.py.
    • Adapted code to import running_in_gunicorn() from src/instana/log.py.
    • Add tests for running_in_gunicorn() to increase the coverage on new code.

@pvital pvital self-assigned this Apr 7, 2026
@pvital pvital added the chore label Apr 7, 2026
@pvital pvital changed the title Ruff update chore: upgrade Ruff configuration and reformat codebase Apr 7, 2026
pvital added 22 commits April 7, 2026 14:38
@pvital
chore: update Ruff's project lint config
bba824e 
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [E117] - Over-indented
49b6a49 
used ruff (pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations, like unused imports.
- isort-compatible import sorting.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [UP031] - Use format specifiers instead of percent f…
f5f05e9 
…ormat.

Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [UP032] - Use f-string instead of format call.
a820ce9 
Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [F401] - {package} imported but unused.
520a69d 
Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [E302] - Expected 2 blank lines, found 1.
75d649f 
Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [CPY001] - Missing copyright notice at top of file.
86aa08c 
Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [E303] - Too many blank lines (2).
4c80d51 
Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [E714] - Test for object identity should be is not.
147675d 
Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [E222] - Multiple spaces after operator.
f602ecd 
Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [FLY002] - Consider f"{start}-{end}" instead of st…
1bb2832 
…ring join.

Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [E266] - Too many leading # before block comment.
42009d9 
Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [SIM300] - Yoda condition detected.
d895a3b 
Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [SIM118] - Use key in dict instead of `key in dict…
a1a47b2 
….keys()`.

Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [SIM105] - Use contextlib.suppress(Exception) inst…
7a9ce60 
…ead of `try`-`except`-`pass`.

Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [SIM910] - Use headers.get(<index>) instead of `he…
08083c5 
…aders.get(<index>, None)`.

Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [SIM117] - Use a single with statement with multip…
53bc26d 
…le contexts instead of nested `with` statements.

Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [SIM102] - Use a single if statement instead of ne…
84ace19 
…sted `if` statements.

Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [SIM103] - Return the condition bool(<CONDITION>) …
c389f78 
…directly.

Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [SIM108] - Use ternary operator instead of if-`els…
2ae4905 
…e`-block.

Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
style: fix error [SIM211] - Use not ... instead of `False if ... el…
3b534e7 
…se True`.

Used Ruff (vscode and pre-commit) to:
- Black-compatible code formatting.
- fix all auto-fixable violations.
- isort-compatible import sorting.
- flake8-simplify manual fixes.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@pvital
fix: SonarQube failed conditions on new code.
3516d15 
- Deleted `src/instana/util/gunicorn.py` since the code is duplicated in `running_in_gunicorn()` function from `src/instana/log.py`.
- Adapted code to import `running_in_gunicorn()` from `src/instana/log.py`.
- Add tests for `running_in_gunicorn()` to increase the coverage on new code.

Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 7, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
3.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@pvital pvital marked this pull request as ready for review April 7, 2026 20:14
@pvital pvital requested a review from a team as a code owner April 7, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pvital pvital

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@pvital