Merged
Conversation
- added method bridge - created event listeners handlers
added 17 commits
May 27, 2021 13:44
- removed example code block
- changed export of handlePushMessage
| Token upload can be handled by [Intercom.sendTokenToIntercom(token)](#intercomsendtokentointercomtoken) | ||
| with token obtained | ||
| from [react-native-notifications](https://wix.github.io/react-native-notifications/api/general-events#registerremotenotificationsregistered) | ||
| ___ |
Contributor
There was a problem hiding this comment.
Could be worth adding an example of where in the application lifecycle you might call this
Contributor
Author
There was a problem hiding this comment.
I can setup react-native-notifications in example app, and link to example, what do you think?
Also react-native-notifications might change
src/index.tsx
Outdated
| IntercomEventEmitter.removeEventListener(); | ||
| event === IntercomEvents.IntercomUnreadCountDidChange && | ||
| Platform.OS === 'android' && | ||
| IntercomEventEmitter.removeEventListener(); |
Contributor
There was a problem hiding this comment.
Maybe it would be better to have a addEventListener and removeEventListener functions. There may be apps that don't want to use effects and would prefer to explicitly remove event listeners
Contributor
Author
There was a problem hiding this comment.
There is problem with removeEventListener in React Native that listener is not removed, remove method should be used on obtained subscription.
Co-authored-by: Sam Murray <sam.murray@intercom.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.